Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tljh-config overwriting bug #122

Closed
choldgraf opened this issue Aug 10, 2018 · 3 comments · Fixed by #124
Closed

tljh-config overwriting bug #122

choldgraf opened this issue Aug 10, 2018 · 3 comments · Fixed by #124

Comments

@choldgraf
Copy link
Member

I noticed a TLJH configuration bug in the latest TLJH. When you use tljh-config to add a new subsection to the YAML, it will over-write the latest section that was written. This only happens if you try to overwrite the same subsection that you most-recently wrote. E.g.:

jupyter-choldgraf@tljh-demo:~/data$ sudo -E tljh-config set blah.doo hellothere

jupyter-choldgraf@tljh-demo:~/data$ tljh-config show
users:
  admin:
  - choldgraf
blah:
  doo: hellothere

jupyter-choldgraf@tljh-demo:~/data$ sudo -E tljh-config set blah.dootwo hellothere

jupyter-choldgraf@tljh-demo:~/data$ tljh-config show
users:
  admin:
  - choldgraf
blah:
  dootwo: hellothere

jupyter-choldgraf@tljh-demo:~/data$ sudo -E tljh-config set blahtwo.doo hellothere

jupyter-choldgraf@tljh-demo:~/data$ tljh-config show
users:
  admin:
  - choldgraf
blah:
  dootwo: hellothere
blahtwo:
  doo: hellothere
@choldgraf
Copy link
Member Author

I'm gonna guess the problem is somewhere around here:

https://github.com/jupyterhub/the-littlest-jupyterhub/blob/master/tljh/config.py#L76

@yuvipanda
Copy link
Collaborator

I suspect this is what is causing the integration tests to fail. Would <3 if someone could take a look :)

@choldgraf
Copy link
Member Author

I'll try to look into this later today if I can get other to-do items done first. I spent my morning TLJH time finishing up those doc PRs and adding these issues :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants