Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding copy button to code blocks and fixing the integration bug #124

Merged
merged 2 commits into from Aug 11, 2018

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Aug 10, 2018

  • Add / update documentation

This PR does two things:

  • adds the sphinx copybutton to the code blocks
  • fixes the bug that was causing integration tests to fail.
    • For some reason the result of loading the yaml was no longer an instance of dict but instead was an instance of CommentedMap. That was causing this line to always return True, which was creating an empty dictionary and removing any previous values in that final node. This PR checks for that type as well and it's now passing tests.

closes #122

@choldgraf choldgraf changed the title adding copy button to code blocks adding copy button to code blocks and fixing the integration bug Aug 11, 2018
@yuvipanda yuvipanda merged commit 627b8d4 into jupyterhub:master Aug 11, 2018
@yuvipanda
Copy link
Collaborator

<3 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tljh-config overwriting bug
2 participants