Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding documentation for GitHub OAuth #117

Merged
merged 1 commit into from Aug 9, 2018
Merged

adding documentation for GitHub OAuth #117

merged 1 commit into from Aug 9, 2018

Conversation

choldgraf
Copy link
Member

@choldgraf choldgraf commented Aug 7, 2018 •
edited

  • Add / update documentation

This adds instructions for setting up the GitHub authenticator with TLJH.

closes #98

cc @jzf2101

@jzf2101
Copy link
Contributor

jzf2101 commented Aug 8, 2018

How do you plan on adding tests? Can we just merge?

@choldgraf
Copy link
Member Author

I think so, I'm not sure if this is testable or not. WDYT @yuvipanda ?

@yuvipanda yuvipanda merged commit da589ce into master Aug 9, 2018
@yuvipanda
Copy link
Collaborator

Yeah, I think we can't add automated tests for these. Let's merge!

@yuvipanda yuvipanda deleted the github_auth branch August 9, 2018 00:56
@jzf2101
Copy link
Contributor

jzf2101 commented Aug 9, 2018

Cool can we take out that item from the PR notes?

@choldgraf
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzf2101 jzf2101 jzf2101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a detailed tutorial on the GitHub authenticator
3 participants
@choldgraf @jzf2101 @yuvipanda