New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] updating content from zexuan's user test #123
Conversation
docs/howto/auth/github.rst
Outdated
IP address** to it. In this case, **you must update your GitHub application information** | ||
with the new IP address. | ||
|
||
Configure your JupyterHub to use the GitHub Oathenticator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oathenticator -> Oauthenticator
Just rebased so the integration tests should pass and there aren't any more conflicts. Also fixed @betatim 's typo spot. |
Also split up the docs requirements files into two files so that we can get the docs tests to pass |
Other option is the full blown 'environment'
Just going to remove need for '-E' instead soon
@choldgraf tyvm for the patch! I've made two changs: rename 'envt' to 'env', and remove the FAQ section. I don't think the sudo -E explanation belongs in FAQ, but I can't figure out a nice place to put it. So instead i'm just going to remove requiring sudo -E for most things in a different PR. Hope that's ok! |
#135 removes -E from all tljh-config commands. I'll think about how to remove it from conda and pip commands. |
@choldgraf just a quick note - I see you had added 'sudo -E' for apt, mkdir etc too in this PR. Those are not necessary. The only commands -E is needed for is tljh-config, the pip and conda we install into the user environments. I've fixed these up as part of #135 |
Cool! No worries. I was putting sudo - E in front of everything just for consistency. It seemed confusing to tell people to only use it sometimes and not other times. If it's used rarely enough, I don't think it's a big dealt tho |
This PR: