New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing extra copybutton files #126
Conversation
24364f9
to
b534b62
Compare
docs/environment.yml
Outdated
- traitlets>=4.1 | ||
- sphinx>=1.4, !=1.5.4 | ||
- pip: | ||
- recommonmark==0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need recommonmark :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops! ok removing that line and merging...I may merge a couple more to get RTD working if something is off
@choldgraf I'll leave this to you to self merge and iterate on! |
df927a5
to
ed3c280
Compare
BTW - do you like my new copybutton CSS? :-) e.g.: https://the-littlest-jupyterhub.readthedocs.io/en/latest/howto/share-data.html |
@choldgraf I do! Did the entire theme change?! |
yeah I dunno what's up with the theme changing, it happened with the other jupyter projects too. I wonder if this is an update to Alabaster? |
@choldgraf yeah, I think so. I love the new theme's typography! Except it's cutting the title of the project awkwardly :) Otherwise <3 |
haha yeah I saw that too, but I agree I think it is cleaner. We can always reduce the H1 size (or whatever that element is) by a little bit :-) |
I just realized that we had an old CSS and JS file from before the "sphinx-copybutton" plugin was a thing. This removes those files, and also updates the docs to use the same readthedocs config that binderhub uses (mostly). I'm gonna self merge this tomorrow AM if the tests pass since it may take some tweaking to get RTD to work properly :-/