Use node 8, not 10 #138
Merged
Use node 8, not 10 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JupyterLab currently doesn't let you install extensions with node 10, so move back to 8
|
/cc @ian-r-rose. LMK when node 10 is supported! |
|
I just merged the PR minutes ago! It's available in jupyterlab master, should be released tomorrow. |
|
@ian-r-rose ah, ok. Then maybe I'll abandon this :D LMK when the release goes out? |
|
Going to actually merge this, since I'm at the PANGEO workshop and we wanna see if we can make a nice pangeo stack plugin. |
yuvipanda
added a commit
to yuvipanda/the-littlest-jupyterhub
that referenced
this pull request
Nov 23, 2018
Reverts jupyterhub#138 and fixes jupyterhub#236.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JupyterLab currently doesn't let you install extensions
with node 10, so move back to 8