test manual https setup #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuvipanda
previously requested changes
Aug 28, 2018
integration-tests/test_proxy.py
Outdated
| os.makedirs(ssl_dir, exist_ok=True) | ||
| os.chmod(ssl_dir, 0o600) | ||
| # generate key and cert | ||
| Popen( |
There was a problem hiding this comment.
Why Popen rather than check_output? Since we aren't calling 'wait' explicitly here there's a race condition here too
adds integration test for manual https certs
|
Thanks, @minrk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds integration test for manual https certs
closes #92