Provide better error message when running on unsupported distro #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This provides a better error message, and bolder text about requiring Ubuntu 18.04. |
yuvipanda
force-pushed
the
ubuntu-version
branch
from
eb575b4
to
1615722
Compare
|
I believe platform will be removed from stdlib in 3.8. I need to check.
…On Wed, Oct 31, 2018, 12:17 Yuvi Panda ***@***.*** wrote:
@yuvipanda <https://github.com/yuvipanda> requested your review on: #221
<#221> Provide
better error message when running on unsupported distro.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#221 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUez8PfUw4Hik89t7zcrwILa4pD0A_tks5uqfdDgaJpZM4YDQ5V>
.
|
|
ahh yea, on https://docs.python.org/2/library/platform.html#platform.linux_distribution I see: looks like the usage for "distro" is pretty similar: |
|
Unfortunately we have to only use stdlib in bootstrap.py. I'll probably switch it to read from /etc/os-release. Thanks for the pointer, @Carreau and @choldgraf |
Since bootstrap.py needs to restrict itself to stdlib python, we read from /etc/os-release than trying to install the distro package.
yuvipanda
force-pushed
the
ubuntu-version
branch
from
cc70702
to
e9462bb
Compare
|
@Carreau @choldgraf I've modified this to use /etc/os-release now! |
|
re-running circle to see if the error was a one-off |
yuvipanda
force-pushed
the
ubuntu-version
branch
from
d9cc499
to
43d9f02
Compare
|
is this ready to go now? |
|
@choldgraf it is! |
|
Awayyyyy we go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186 #206