Exit when tljh-config is called as non-root #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously, we only printed warning and did not exit - Split the warning over two lines rather than one - -E is not required for tljh-config anymore (since it is in /usr/bin, not /usr/local/bin), so do not ask users to use it. jupyterhub#135 is the PR that made this change, and changed documentation in most places.
|
I think warning and not exit is the right thing to do, since properly configured admin permissions shouldn't require root, only erroring if/when there is an actual permission error. What do you think? |
40 tasks
|
I'm not sure what I think would be best with regards to a decisive exit or emitting a warning - I lean towards exit as I value a decisive error message. No matter on the topic on warning vs error, I think this part is relevant and should not be lost by just closing this PR.
|
|
Ya given #51 I think this is ready to merge as is |
|
Let's go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/usr/bin, not /usr/local/bin), so do not ask users to use it.
Move tljh-config symlink to /usr/bin #135
is the PR that made this change, and changed documentation in
most places.
Followup #120