Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tljh logger in installer #248

Merged
merged 1 commit into from Dec 12, 2018
Merged

Use tljh logger in installer #248

merged 1 commit into from Dec 12, 2018

Conversation

fm75
Copy link
Contributor

@fm75 fm75 commented Dec 12, 2018

  • Add / update documentation
  • Add tests

@fm75
Copy link
Contributor Author

fm75 commented Dec 12, 2018

Fixes #241
In tljh/installer.py the following functions were not logging (I have a simulation in another branch that demontrates that)

  • ensure_usergroups
  • ensure_user_environment
  • ensure_admins
  • ensure_jupyterhub_running
  • run_plugin_actions
  • main

Also, tljh/migrate.py was not logging (for the same reason, but I have not demonstrated that.)

@yuvipanda yuvipanda merged commit ae9bf70 into jupyterhub:master Dec 12, 2018
@yuvipanda
Copy link
Collaborator

Thank you for the PR, @fm75 :)

@fm75 fm75 mentioned this pull request Dec 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fm75 @yuvipanda