Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix GitHub login config missing callback URL #261

Merged
merged 2 commits into from Jan 31, 2019
Merged

fix GitHub login config missing callback URL #261

merged 2 commits into from Jan 31, 2019

Conversation

huhuhang
Copy link
Contributor

  • Add / update documentation
  • Add tests

yuvipanda
yuvipanda approved these changes Jan 31, 2019
View reviewed changes
Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! There's a small syntax error - once we fix that, we can merge this.

Thank you very much for your PR, @huhuhang! <3

docs/howto/auth/github.rst Show resolved Hide resolved
@yuvipanda @huhuhang
Update docs/howto/auth/github.rst
d7ad9dd 
Co-Authored-By: huhuhang <huhuhang@users.noreply.github.com>
@yuvipanda yuvipanda merged commit cfe3aae into jupyterhub:master Jan 31, 2019
@yuvipanda
Copy link
Collaborator

Thank you very much! The test failures are fixed in other PRs, so going to merge this now.

Hope to see more PRs in the future! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda yuvipanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huhuhang @yuvipanda