Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin tornado to <6 #292

Merged
merged 2 commits into from Mar 9, 2019
Merged

Pin tornado to <6 #292

merged 2 commits into from Mar 9, 2019

Conversation

willirath
Copy link
Collaborator

@willirath willirath commented Mar 8, 2019 •
edited

See #290. Users reported Kernel connection issues with tornado >= v6. Let's see if this fixes it.

@willirath willirath requested a review from minrk March 8, 2019 11:25
@willirath willirath mentioned this pull request Mar 8, 2019
Closed
@PaluchowskiMatthew
Copy link

@willirath
problem persists and tornado version remains 6.0.1
image

@willirath
Copy link
Collaborator Author

@PaluchowskiMatthew thanks for checking. With af26b22, tornado should be pinned in the user env.

@yuvipanda yuvipanda merged commit badf25c into master Mar 9, 2019
@yuvipanda
Copy link
Collaborator

Thank you, @willirath

@willirath willirath mentioned this pull request Mar 10, 2019
Closed
@consideRatio consideRatio deleted the willirath-pin-tornado-5 branch October 19, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minrk minrk Awaiting requested review from minrk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@willirath @PaluchowskiMatthew @yuvipanda