Upgrade to JupyterHub 1.0 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bump oauthenticator patch as well
|
@minrk awesome! Do you think we should put upgrade-db in pre-start for JupyterHub service here, similar to what we do in z2jh? |
|
Yeah, that's a good idea. |
|
@minrk let me know if my change looks good |
|
Not sure yet why this is failing. |
|
Debugging the integration tests can be hard, since we get little feedback about the errors. It would be good to show logs on failure. I'll look into it today. |
|
@minrk did you manage to find any time to look into this? |
This was referenced May 19, 2019
- It's a no-op if we aren't upgrading hub versions. - We know we're only using sqlite, since we are an opinionated distro! - This matches what we do in z2jh
|
Instead of using pre-start, I have instead passed --upgrade-db to the JupyterHub process itself. This matches what we do in z2jh. |
|
Tests pass, yay! |
|
I'll merge this one now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump oauthenticator patch as well