Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup HTTPS documentation #328

Merged
merged 3 commits into from May 28, 2019
Merged

Cleanup HTTPS documentation #328

merged 3 commits into from May 28, 2019

Conversation

yuvipanda
Copy link
Collaborator

@yuvipanda yuvipanda commented May 18, 2019 •
edited

  • Wrap some lines
  • Normalize reference anchors to conform to hierarchy
  • Mention that the certificates will be renewed
  • Strengthen suggestion to use Let's Encrypt
  • Note that Let's Encrypt doesn't work in internal
    networks not accessible from the internet
  • Note that you need a domain name before you can
    set up HTTPS
  • Add section on troubleshooting HTTPS
  • Add section on getting traefik logs, and remove section
    on configurable-http-proxy (which we no longer use)

Fixes #305
Fixes #217

  • Add / update documentation

@yuvipanda
Cleanup HTTPS documentation
10e60ab 
- Wrap some lines
- Normalize reference anchors to conform to hierarchy
- Mention that the certificates will be renewed
- Strengthen suggestion to use Let's Encrypt

Fixes jupyterhub#305
@yuvipanda
Document that you need a domain name before HTTPS
a569417 
Also note that Let's Encrypt doesn't work in private
networks.

Fixes jupyterhub#217
@yuvipanda yuvipanda mentioned this pull request May 19, 2019
Closed
@yuvipanda
Add bit more info on troubleshooting HTTPS
9f776c2 
We no longer use CHP, so add section on getting logs from
traefik instead
@yuvipanda yuvipanda mentioned this pull request May 20, 2019
Closed
@yuvipanda yuvipanda requested a review from minrk May 20, 2019 16:46
@yuvipanda yuvipanda added this to the v1.0 milestone May 20, 2019
@yuvipanda yuvipanda merged commit abb3e15 into jupyterhub:master May 28, 2019
@yuvipanda yuvipanda mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minrk minrk Awaiting requested review from minrk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Document renewal process for HTTPS certificates Make it clearer that you always need a domain name for HTTPS
1 participant
@yuvipanda