Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to deploy on Azure #342

Merged
merged 21 commits into from May 24, 2019

Conversation

trallard
Copy link
Contributor

@trallard trallard commented May 20, 2019

  • Add / update documentation
  • Add tests

This PR adds the instructions to set a suitable VM for the littles JupyterHub on Azure.

@yuvipanda
Copy link
Collaborator

Thank you for opening the PR!

Do you think there's a way to set this up without requiring the user to ssh? I'd love for us to keep all the installation instructions for cloud providers to not need ssh. Usually this is done with a user-data (or cloud-init) textbox field. Does Azure have one?

I'd also like us to keep the 'step 1', 'step 2', 'step 3', 'step 4', etc same between the cloud providers.

The deletion documentation is very useful, and should probably go in a file under https://github.com/jupyterhub/the-littlest-jupyterhub/tree/master/docs/howto/providers.

Thank you for working on adding this!

@trallard
Copy link
Contributor Author

No worries will fix this ASAP (re steps and the such)

And find a way to avoid the ssh-ing into the VM

@trallard trallard changed the title Add instructions to deploy on Azure [WIP] Add instructions to deploy on Azure May 20, 2019
@trallard trallard changed the title [WIP] Add instructions to deploy on Azure Add instructions to deploy on Azure May 21, 2019
@trallard
Copy link
Contributor Author

trallard commented May 21, 2019

@yuvipanda I have added the changes you requested, namely:

  • Make sure the steps are consistent with the other providers
  • Install TLJH using cloud-init
  • Move the stop and deletion details to the howto/providers/azure.rst

And improved the wording on the doc in general 🎉

@yuvipanda yuvipanda self-requested a review May 21, 2019 17:08
Copy link
Collaborator

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving to this format! I've suggested minor changes, but otherwise good to go! There are a bunch of references to LTJH instead of TLJH. Is that intentional?

Thank you very much for the PR! ❤️

docs/install/azure.rst Outdated Show resolved Hide resolved
docs/howto/providers/azure.rst Outdated Show resolved Hide resolved
docs/howto/providers/azure.rst Show resolved Hide resolved
docs/install/azure.rst Show resolved Hide resolved
@trallard
Copy link
Contributor Author

Done!

Thanks for moving to this format! I've suggested minor changes, but otherwise good to go! There are a bunch of references to LTJH instead of TLJH. Is that intentional?

Not intentional, just my dyslexia creeping in

@yuvipanda
Copy link
Collaborator

@trallard awesome! I made a few minor rst syntax fixes, will merge once the tests pass.

If folks file issues here about the azure instructions, is it ok to cc you on those issues?

@yuvipanda yuvipanda merged commit 97d3c3a into jupyterhub:master May 24, 2019
@yuvipanda
Copy link
Collaborator

<3 merged! Thanks, @trallard

@trallard
Copy link
Contributor Author

💜 thanks @yuvipanda! Sure thing feel free to @ me in any issues related to azure here or any Jupyter related things. I'd be more than happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants