Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade while https enabled #347

Merged
merged 2 commits into from May 28, 2019
Merged

Upgrade while https enabled #347

merged 2 commits into from May 28, 2019

Conversation

GeorgianaElena
Copy link
Member

As discussed in #277:

  • Mark requests as an explicit dependency (it comes in as a transient dependency now)
  • Switch from urllib to requests
  • Set verify=False with a comment on why

@yuvipanda yuvipanda closed this May 24, 2019
@yuvipanda yuvipanda reopened this May 24, 2019
@yuvipanda
Copy link
Collaborator

w00t, thanks @GeorgianaElena!

Travis seems stuck, closing and re-opening PR doesn't seem to help..

@GeorgianaElena
Copy link
Member Author

@yuvipanda, I manged to trigger travis by rerunning the tests on my branch ❤️

@yuvipanda yuvipanda merged commit 02040e1 into jupyterhub:master May 28, 2019
@yuvipanda
Copy link
Collaborator

Awesome, @GeorgianaElena! <3 thank you!

@GeorgianaElena GeorgianaElena deleted the issue277 branch September 19, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GeorgianaElena @yuvipanda