Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs addition #364

Merged
merged 14 commits into from Oct 22, 2020
Merged

Docs addition #364

merged 14 commits into from Oct 22, 2020

Conversation

kafonek
Copy link
Contributor

@kafonek kafonek commented Jun 5, 2019

Update to the docs for plugin information and "shared directory" configurations.

Apologies if the .rst format is slightly off, it was hard to evaluate what it will look like in tljh.jupyter.org since there's no jupyterlab renderer and github rendering of rst is a bit different.

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kafonek 👋 Sorry for the late reply.
I've rebased this PR and added a few commits to make it match the current docs structure. Hope that's ok.
Merging it now. Thanks a lot 🎉

@GeorgianaElena GeorgianaElena merged commit 2ea3339 into jupyterhub:master Oct 22, 2020
@welcome
Copy link

welcome bot commented Oct 22, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants