Support using arbitrary set of installed authenticators #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
===========================================
+ Coverage 22.48% 42.51% +20.02%
===========================================
Files 6 6
Lines 249 254 +5
===========================================
+ Hits 56 108 +52
+ Misses 193 146 -47
Continue to review full report at Codecov.
|
|
I hadn't intended to set up codecov to shame me if code coverage dropped, but it did and i added more tests! I call this a win! |
We don't wanna explicitly map keys from the YAML to traitlet config for the authentication - that's a lot of busywork for no gain. We instead switch to using snake_case everywhere, and dynamically set traitlet config from YAML config!
yuvipanda
force-pushed
the
authenticator-support
branch
from
63e3f7a
to
66de7bb
Compare
- Removes all need for special casing authenticators. - Install them in hub environment, directly start using them. - Consider if we should special case any *at all*
yuvipanda
changed the title
|
I'm also going to say that we don't merge new PRs until they're documented, so I'm going to add docs to this before we can merge it. |
No two ways to set authenticator options - just one way. It's slightly 'ugly' because of the mixing of camel case & snake case, but is worth the massive reductions in complexity!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't wanna explicitly map keys from the YAML to traitlet
config for the authentication - that's a lot of busywork for no
gain. We instead switch to using snake_case everywhere, and
dynamically set traitlet config from YAML config! This lets users
pick any authenticator by specifying the fully qualified authenticator
name, and set properties using the class name. This takes us out
of the critical path for using arbitrary authenticators.
We also add OAuthenticator & LDAPAuthenticator to the base install here.
Refer #36