Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tljh_post_install hook #389

Merged
merged 2 commits into from Jul 2, 2019
Merged

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented Jun 27, 2019

Add a new tljh_post_install hook to allow the execution of arbitrary post install actions.

  • Add / update documentation
  • Add tests


@hookimpl
def tljh_post_install():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this test be something much simpler, like writing a random token to a file and verifying that? :D Just wanted to keep test runtime and complexity down

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, should be fixed by b96a760.

@yuvipanda yuvipanda merged commit 5315919 into jupyterhub:master Jul 2, 2019
@yuvipanda
Copy link
Collaborator

Thanks, @jtpio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants