Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are failing for some time :( However, the strange thing is that the tests in test_conda.py all pass if ran individually.
At first I thought this might be related to the newer version of pytest (since the tests passed if each of it got its own instance of the
prefix
fixture). But there wasn't any pytest change to justify the behavior.After more digging, the issue I noticed is that after the first
conda.ensure_conda_packages
call, the environment got modified and instead of having symlinks to python3.6, there were instead to python3.7, hence the "ModuleNotFoundError: No module named 'conda'" error.conda-meta/history contents before the running any test
conda-meta/history contents after the running first test (conda.ensure_conda_packages(prefix, ['numpy']))
Because in TLJH we're using conda 4.5.8, I think whatever is going on with the version in tests is not the case in TLJH (the test passes if we use the same conda 4.5.8)