Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ready to merge] - Update Azure docs #448

Merged
merged 8 commits into from Oct 22, 2019
Merged

[Ready to merge] - Update Azure docs #448

merged 8 commits into from Oct 22, 2019

Conversation

trallard
Copy link
Contributor

  • Add / update documentation
  • Add tests

This PR tackles the improvements suggested in #388 by @choldgraf

@trallard trallard changed the title Trallard patch docs [WIP] - Update . Azure docs Oct 19, 2019
@trallard trallard changed the title [WIP] - Update . Azure docs Update Azure docs Oct 21, 2019
@trallard trallard changed the title Update Azure docs [Ready to merge] - Update Azure docs Oct 21, 2019
@trallard
Copy link
Contributor Author

trallard commented Oct 21, 2019 •
edited

This PR is ready to merge 🎉 it contains:

  • Updates to the Azure setup instructions with images matching the latest Azure portal version
  • Updates to how to adding instructions to decommission the whole resource group

@yuvipanda please let me know if there are any changes you'd like me to make

@yuvipanda yuvipanda merged commit 3cea0cb into jupyterhub:master Oct 22, 2019
@yuvipanda
Copy link
Collaborator

Thanks a lot for working on this, @trallard!!!

@choldgraf
Copy link
Member

wohoo! thanks so much @trallard :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trallard @yuvipanda @choldgraf