New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch base environment to requirements file #457
Conversation
0fb8a6b
to
4a5a06f
Compare
@minrk totally agree re: freeze. Failing with:
With 1.1 we don't need hub-extension either. |
I ran into this problem (jupyterlab failing to build) on my TLJH deployment on DO when I upgraded jupyterlab manually from 0.35.4 to 1.2.5. I tried to solve the failing tests in this PR it in the same manner but with no luck :( Either there's something missing or the tests are failing from a whole different reason. |
@GeorgianaElena I wonder if this needs a rebase - we fixed some other errors in master after this PR I think. |
Another reason for flaky build is that Webpack minify process is resource intensive, which might cause flaky build on pipelines with smaller machines. add |
and update several dependencies in the process (jupyterlab 1.1, notebook 6.0, etc.)
6b1d847
to
9eb13cb
Compare
I've rebased the PR and now it contains @letianw91 's fix 🚀 |
Awesome, ty @GeorgianaElena! |
requirements file is easier to work with and update than inlined strings
In the future, we should be doing
pip freeze
and using the frozen result, like we do (with conda) in repo2docker because pinning only direct dependencies is a way to guarantee broken environments in the future (see the pinning-down of tornado as one example).Several dependencies are updated in the process (jupyterlab 1.1, notebook 6.0, etc.)