New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade jupyterlab to 1.2.6 #499
Upgrade jupyterlab to 1.2.6 #499
Conversation
Getting this error in the CI build. I feel like this is a race-condition/flaky build problem: Some concurrent running test process resulted in a temp sqlite file that existed at list folder time but have disappeared at permission check time. |
It feels weird to add a special option to the installer just to get it to pass on the CI. However there is jupyterlab/jupyterlab#7180 which also does this and (found via that issue) the https://github.com/jupyter/docker-stacks/ images also use this option. With multiple lab extensions you can use something like the following to only build things once instead of for each extension you install:
|
I don't think we run our test suite in parallel so the flakeyness must come from somewhere else :-/ |
Yep, I agree it is weird to do this. The main culprit is how much memory Webpack minify uses, and it has hang a t3.small machine on AWS (2GB memory) when I tested TLJH. So in a way it is solving a problem of deploying TLJH on a small test machine. But adding an adhoc option like this look ugly :( The suggested method is good, and is actually how I tend to build lab extensions myself. Will update to use this method. |
Nice work, merging! |
This PR upgrades Jupyterlab to the latest version of 1.2.6 as of Feb 1st 2020. Build and integration tests passes locally.
jupyterlab-hubextension
removed because this has been integrated to Jupyterlab 1.0.0+Added
--minimize=False
option to Jupyterlab installation to avoid flaky build on low resource CI pipelinesAdd / update documentation
Add tests