Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing reference to requirements-base.txt #504

Merged
merged 1 commit into from Feb 4, 2020

Conversation

GeorgianaElena
Copy link
Member

Include requirements-base.txt in MANIFEST so it gets installed.
Fixes #502

@yuvipanda yuvipanda merged commit 044f159 into jupyterhub:master Feb 4, 2020
@yuvipanda
Copy link
Collaborator

Thanks, @GeorgianaElena!

@betatim
Copy link
Member

betatim commented Feb 5, 2020

To catch errors with the manifest files we'd have to run our integration tests in/from a copy of the repo that was created by some kind of bundling tool right? I was surprised we didn't catch this in the integration tests and trying to understand why.

@GeorgianaElena
Copy link
Member Author

My guess is that it has something to do with the checkout step in our circleci config.
Expand the checkout code in our tests to see what circleci is doing.

I believe because of this, even if we build tljh here without the requirements file lets say, it will still find the file because it has access to the source code. In a production scenario, this doesn't happen.

P.S. I'm not sure if I'm making any sense, this is just a hunch (it hard to understand how circleci works).

@GeorgianaElena GeorgianaElena deleted the fix_req_bug branch February 5, 2020 07:44
@betatim
Copy link
Member

betatim commented Feb 6, 2020

Thanks for investigating. Debugging CI setups is no fun :-/ Looks like #503 is a good place to track and work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install issues on Ubuntu 18.04
3 participants