Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a quick note about DNS records #532

Merged
merged 1 commit into from Mar 12, 2020

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented Mar 9, 2020

Extend the note about DNS records, so that it's easier to know what needs to be done to point to the IP of the server.

image

  • Add / update documentation
  • Add tests

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio! I've re-based the PR and everything is green now 🎊

@GeorgianaElena GeorgianaElena merged commit 8593860 into jupyterhub:master Mar 12, 2020
@jtpio jtpio deleted the dns-screenshot branch March 12, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants