Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused plugins argument from run_plugin_actions #560

Merged
merged 1 commit into from May 14, 2020
Merged

Remove unused plugins argument from run_plugin_actions #560

merged 1 commit into from May 14, 2020

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented Apr 29, 2020 •
edited

In the run_plugin_actions function, hooks are retrieved from the plugin_manager, and the plugins argument doesn't seem to be used.

This change removes the unused plugins argument.

  • Add / update documentation (installer internals)
  • Add tests

GeorgianaElena
GeorgianaElena approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jtpio 🌞

@GeorgianaElena GeorgianaElena merged commit efb1f64 into jupyterhub:master May 14, 2020
@jtpio jtpio deleted the unused-plugins-argument branch May 14, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgianaElena GeorgianaElena GeorgianaElena approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jtpio @GeorgianaElena