Use sha256 sums for verifying miniconda download #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also gives us the possibility of using miniforge if we want to. I'd love for us to move to that eventually, as it is more of a community effort than miniconda. |
|
This looks like an out of memory error again, but with conda install this time. |
|
@yuvipanda, this time the error doesn't go away after a few test reruns 😕. |
miniconda downloader now provides sha256 hashes. Previously it provided only md5 hashes. md5 is deprecated everywhere for everything, so let's use this
GeorgianaElena
force-pushed
the
feat/sha256
branch
from
ac469cd
to
f82c49c
Compare
|
@yuvipanda, I've ended up increasing the memory to 1.15G and rebased this PR to make everything green again. I'm going to hit merge. Thanks @yuvipanda 🎉 ❤️ |
|
Sorry I missed this, @GeorgianaElena! Thanks for taking care of it! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
miniconda downloader now provides sha256 hashes. Previously
it provided only md5 hashes. md5 is deprecated everywhere for
everything, so let's use this