Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -L option to curl to follow redirect #593

Merged
merged 2 commits into from Jul 8, 2020

Conversation

LTangaF
Copy link
Contributor

@LTangaF LTangaF commented Jun 29, 2020

to new bootstrap location

  • Add / update documentation
  • Add tests

to new bootstrap location
@welcome
Copy link

welcome bot commented Jun 29, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@LTangaF
Copy link
Contributor Author

LTangaF commented Jun 29, 2020

This is a minor documentation fix. Not sure how testable that is from an automated perspective. I tested it in AWS, though.

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job spotting this @LTangaF ❤️ and thanks a lot for opening this PR.

Do you mind adding the curl follow redirect flag to the other places in the docs? (and the integration upgrade test):
I believe this are all the occurrences that should be changed:
redirect-locations

@LTangaF
Copy link
Contributor Author

LTangaF commented Jun 30, 2020

I didn't realize there was a test for the documentation changes. It looks like it came up green here without it, which is interesting.

I'll work on those other doc changes.

@GeorgianaElena
Copy link
Member

I didn't realize there was a test for the documentation changes. It looks like it came up green here without it, which is interesting.

There isn't any test for doc changes that would error from this. I think the red from my grep command output was misleading. Sorry for that.

I'll work on those other doc changes.

Thanks a lot for working on this ❤️

@LTangaF
Copy link
Contributor Author

LTangaF commented Jul 8, 2020

I updated the integration test as well.

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going the extra mile and fixing the docs for all the cloud providers ❤️

@GeorgianaElena GeorgianaElena merged commit 489ddfc into jupyterhub:master Jul 8, 2020
@welcome
Copy link

welcome bot commented Jul 8, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants