Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http port from config while checking hub #598

Merged
merged 1 commit into from Jul 28, 2020

Conversation

dongmok
Copy link
Contributor

@dongmok dongmok commented Jul 21, 2020

This patch loads the configuration to specify http port while checking the hub, to fix the issue #588

On check_hub_ready

  • Add / update documentation
  • Add tests

@welcome
Copy link

welcome bot commented Jul 21, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @dongmok, thanks 🎉

There was a issue with the tests (the failures are unrelated with your changes), but that should be fixed now. Do you mind rebasing your PR to make sure everything's green?

@GeorgianaElena
Copy link
Member

@dongmok, hope you don't mind that I've force-pushed the changes from tljh-master to your fork, so that we only have your commit in this PR.

Once everything is green, I plan to merge 🎉 Thanks a lot for solving the issue 🌻

@dongmok
Copy link
Contributor Author

dongmok commented Jul 28, 2020

@dongmok, hope you don't mind that I've force-pushed the changes from tljh-master to your fork, so that we only have your commit in this PR.

No problem. Thanks

@GeorgianaElena GeorgianaElena merged commit 462b01c into jupyterhub:master Jul 28, 2020
@welcome
Copy link

welcome bot commented Jul 28, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants