Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to jupyterhub-idle-culler #607

Merged
merged 3 commits into from Aug 25, 2020

Conversation

1kastner
Copy link
Contributor

See #584

  • Add / update documentation

@welcome
Copy link

welcome bot commented Aug 23, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@GeorgianaElena
Copy link
Member

Thanks a lot @1kastner for the much needed documentation update ❤️

@1kastner
Copy link
Contributor Author

1kastner commented Aug 25, 2020

That sounds great to me. A slight change I'd prefer:

The idle culler is installed and enabled by default in TLJH and can be configured using tljh-config. For advanced use-cases, like purging old user data, the idle culler configuration can be extended beyond tljh-config options, using custom jupyterhub_config.py snippets

@GeorgianaElena
Copy link
Member

It sounds great @1kastner 🚀

@1kastner
Copy link
Contributor Author

@GeorgianaElena I hope I got it right in the RST document!

@GeorgianaElena
Copy link
Member

It looks good @1kastner (you can find the docs for this PR rendered here: https://the-littlest-jupyterhub--607.org.readthedocs.build/en/607/topic/idle-culler.html)
I just added a commit to re-add the link to the idle culler repo.

Merging this. Thanks! ❤️

@GeorgianaElena GeorgianaElena merged commit 7bf2a64 into jupyterhub:master Aug 25, 2020
@welcome
Copy link

welcome bot commented Aug 25, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@1kastner
Copy link
Contributor Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants