Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build #624

Merged
merged 3 commits into from Oct 20, 2020
Merged

Conversation

GeorgianaElena
Copy link
Member

@GeorgianaElena GeorgianaElena commented Oct 20, 2020

The RTD build was failing with TemplateNotFound('about.html') error. I believe this was because, before pydata-sphix-theme v.0.4.1, there was no html_sidebars feature (thanks @choldgraf for adding it 馃コ), so it was not complaining that we were still using the sidebars from the old one. Removing the old sidebars and using the ones from the new theme, seams to be fixing the issue.

(This also fixes the left TOC for the how-to docs section)

@GeorgianaElena GeorgianaElena marked this pull request as ready for review October 20, 2020 12:33
@GeorgianaElena GeorgianaElena merged commit 88ea1bc into jupyterhub:master Oct 20, 2020
@GeorgianaElena GeorgianaElena mentioned this pull request Oct 20, 2020
@choldgraf
Copy link
Member

wooo, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants