Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to call sudo with changed path #632

Merged
merged 1 commit into from Nov 20, 2020
Merged

Conversation

namin
Copy link
Contributor

@namin namin commented Nov 14, 2020

No description provided.

@welcome
Copy link

welcome bot commented Nov 14, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @namin! I noticed that on my Ubuntu it works both with and without env, but it might be different for other distributions (looking at the sudo man page for CentOs, it looks like it explicitly needs the env part). So I'm going to merge this 🚀 Thank you!

@GeorgianaElena GeorgianaElena merged commit bf291aa into jupyterhub:master Nov 20, 2020
@welcome
Copy link

welcome bot commented Nov 20, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants