Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a necessary step to reset password #636

Merged
merged 1 commit into from Nov 25, 2020

Conversation

mauro3
Copy link
Contributor

@mauro3 mauro3 commented Nov 24, 2020

I had to do this additional step to allow the user to log-in again.

(I did not build the docs and I am not a rst person, but I think the change should be valid rst.)

  • Add / update documentation
  • Add tests

I had to do this additional step to allow the user to log-in again.

(I did not build the docs and I am not a rst person, but I think the change should be valid rst.)
@welcome
Copy link

welcome bot commented Nov 24, 2020

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@GeorgianaElena GeorgianaElena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mauro3 ❤️

  • A cool thing added by readthedocs recently is to see previews of the documentation per pull request. You can see how your changes look in the docs at this link, https://the-littlest-jupyterhub--636.org.readthedocs.build/en/636/, which you can find in the list of checks performed for this PR:
    rtd-preview

  • I find this very helpful, especially since I almost always make a mistake when writing rst 😅 I hope it is for you too 🌻

  • I'm not sure if you know (since it isn't int the docs :( ), but there's another way for a user to change their password (when the default authenticator is used in TLJH), by going to this link: <your_server_ip>/hub/auth/change-password. Some time ago I opened an issue about documenting this: Document how to change password when using FirstUseAuthenticator and NativeAuthenticator #523. Do you want to open another Pull Request to add this info to the docs too ❤️?

Thank you so much for this PR and congratulations for your first PR to this project 🥳 ❤️

@GeorgianaElena GeorgianaElena merged commit 9ada0d8 into jupyterhub:master Nov 25, 2020
@welcome
Copy link

welcome bot commented Nov 25, 2020

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@mauro3
Copy link
Contributor Author

mauro3 commented Nov 26, 2020

Thanks! That's a good trick to know. I already found that pwd change trick, I can make a PR for that too: #637.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants