Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py: Update repo URL #656

Merged
merged 1 commit into from Mar 21, 2021
Merged

setup.py: Update repo URL #656

merged 1 commit into from Mar 21, 2021

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Feb 4, 2021

No description provided.

@welcome
Copy link

welcome bot commented Feb 4, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

jtpio
jtpio reviewed Feb 8, 2021
View reviewed changes
setup.py Outdated
Comment on lines 8 to 9
author='Yuvi Panda',
author_email='yuvipanda@gmail.com',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these fields also be updated to match the ones from the jupyterhub project, since TLJH is also an official sub-project?

https://github.com/jupyterhub/jupyterhub/blob/2e198396c172b6e4cdfc023466a9eb29467d0a92/setup.py#L91-L93

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree - @jayvdb do you think you can do that? Happy to merge after.

Apologies for the late review!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated author fields

@yuvipanda
Copy link
Collaborator

Thanks, @jayvdb! The fail seems unrelated, so am going to merge this.

@yuvipanda yuvipanda merged commit 7473991 into jupyterhub:master Mar 21, 2021
@welcome
Copy link

welcome bot commented Mar 21, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvipanda yuvipanda yuvipanda left review comments

@jtpio jtpio jtpio left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jayvdb @yuvipanda @jtpio