Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add missing gif for the TLJH is building page #662

Merged
merged 1 commit into from Feb 18, 2021

Conversation

jtpio
Copy link
Contributor

@jtpio jtpio commented Feb 15, 2021

Without this gif, the docs fail to build locally:

reading sources... [100%] topic/customizing-installer

Warning, treated as error:
/path/to/the-littlest-jupyterhub/docs/topic/customizing-installer.rst::image file not readable: topic/../images/tljh-is-building-page.gif
make: *** [Makefile:20: html] Error 2

Adding the gif from #605 seems to be fixing it.

Before

https://tljh.jupyter.org/en/latest/topic/customizing-installer.html?#serving-a-temporary-tljh-is-building-page

image

After

image

  • Add / update documentation
  • Add tests

@GeorgianaElena
Copy link
Member

Ooops, forgot about the gif! Thank you for spotting and fixing this, @jtpio :D

@GeorgianaElena GeorgianaElena merged commit 2f156e6 into jupyterhub:master Feb 18, 2021
@jtpio jtpio deleted the tljh-building-gif branch February 18, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants