Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions for restarting JupyterHub to docs (re: #455) #666

Merged
merged 2 commits into from Oct 16, 2021

Conversation

DataCascadia
Copy link
Contributor

In the Troubleshooting section of the docs I created a file restart.rst with the instructions for stopping and restarting JupyterHub in response to issue #455. I linked to this document in the troubleshooting index.rst.

I made this contribution as part of PyCascades sprints. I have never used JupyterHub or restructured text before, so someone should confirm the content is correct and formatted correctly. I did my best to follow the formatting in the other docs.

  • Add / update documentation
  • Add tests

@welcome

This comment has been minimized.

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and seems reasonable.

I note that the indentation wasn't as I expected, but also that the documentation is full of inconsistencies with regards to that, so this is consistent to some but not all other sections - due to that this is fine and those changes should be done in a dedicated PR.

docs/troubleshooting/restart.rst Outdated Show resolved Hide resolved
docs/troubleshooting/restart.rst Outdated Show resolved Hide resolved
@consideRatio consideRatio merged commit d9e525d into jupyterhub:master Oct 16, 2021
@welcome
Copy link

welcome bot commented Oct 16, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants