Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Switch integration and upgrade tests from CircleCI to GitHub actions"" #678

Merged
merged 5 commits into from Apr 5, 2021
Merged

Revert "Revert "Switch integration and upgrade tests from CircleCI to GitHub actions"" #678

merged 5 commits into from Apr 5, 2021

Conversation

yuvipanda
Copy link
Collaborator

Reverts #677

Brings back #673,
needs to be properly tested :(

@GeorgianaElena
Copy link
Member

@yuvipanda, this should be ready for review again.
I've get rid of the use of GITHUB_ACTOR and replaced that with GITHUB_REPOSITORY and GITHUB_SHA with GITHUB_REF (ref GHA default env vars). This should make the tests run ok both on pull_request events as well as push events.

@yuvipanda yuvipanda merged commit 17162cb into master Apr 5, 2021
@yuvipanda
Copy link
Collaborator Author

ok, let's try it!

@consideRatio consideRatio deleted the revert-677-revert-673-switch-gha branch October 19, 2021 11:40
@GeorgianaElena GeorgianaElena mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuvipanda @GeorgianaElena