Launch into /lab by default by changing TLJH config's default value
#775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for opening this @raybellwaves!
I don't feel comfortable enough to merge this, because I believe this needs some discussion before. For example, there is a conversation about this in z2jh which I believe concluded that migrating to JupyterHub 2.0 which defaults to JupyterLab is the way to go.
Maybe we can do the same for TLJH and focus on migrating to JupyterHub 2.0, and then figure what needs to change in order to accommodate the hub's default interface.
|
If we resolve #724 this should be easier to deal with |
|
I rebased this PR and pushed a commit updating the docs about this change, and adding a breaking change changelog entry about it. |
consideRatio
approved these changes
Aug 9, 2023
minrk
approved these changes
Aug 9, 2023
consideRatio
changed the title
/lab by default by changing TLJH config's default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default value for the TLJH config
user_environment.default_apptojupyterlab, which makesc.Spawner.default_urlbe set to/labby default in TLJH.To revert to the behavior before this, a TLJH admin can do:
Closes #773