bootstrap script accepts a version #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manics
changed the title
GeorgianaElena
added
enhancement
There was a problem hiding this comment.
This is just great! I really appreciate the tests. Thanks a lot @manics!
Some docs about this would be amazing, but not a blocker for this PR in my opinion.
|
Ooooh beautiful! I was thinking that a line of code was wrong, then saw amazing tests that demonstrated that the code worked, and then realized what I got wrong thinking a line of code was wrong! This looks great to me and is a clear improvement without drawback I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of #724
This should allow:
cat bootstrap.py | python3 - --version <branchname-or-dev-tag>cat bootstrap.py | python3 - --version <commit-sha>cat bootstrap.py | python3 - --version major.minor.patchcat bootstrap.py | python3 - --version major.minorlatest major.minor releasecat bootstrap.py | python3 - --version majorlatest major releasecat bootstrap.py | python3 - --version latestlatest released tagcat bootstrap.py | python3 -install frommainbranch (current default, though this should be changed tolatestwhen there's a release tag)Obviously this can't be properly tested since there are no tags 馃槂. However I've added some mock tests in
test_bootstrap_functions.py. Since https://tljh.jupyter.org/en/latest/ is a live site we can't add documentation on using--version RELEASEuntil we've made a tag.