Traefik v2, TraefikProxy v1 #861
Conversation
minrk
force-pushed
the
traefik-v2
branch
3 times, most recently
from
45b4550
to
9b269d9
Compare
- traefik releases are tarballs now - move traefik platform check to download function for easier unit testing on unsupported platforms
minrk
force-pushed
the
traefik-v2
branch
4 times, most recently
from
ca9944d
to
5015f4f
Compare
- tls config is no longer allowed in static config file, add separate dynamic config - no longer need to persist auth config ourselves (TraefikProxy handles this) - make sure to reload proxy before reloading hub in tests
minrk
force-pushed
the
traefik-v2
branch
2 times, most recently
from
0ded20b
to
d3aea5b
Compare
verified this works now
for easier testing
|
Wieee tests are passing, ping me for review when its ready for review @minrk! |
|
Tests are passing and I did a test deployment to verify that the letsencrypt config works. Good to go from me! |
|
@minrk can you update title, PR description, and labels? If there is breaking changes, can you clarify them in the PR description in a dedicated section as well? My rough understanding is that we are updating the traefik-proxy, and setting it up to work against traefik v2 instead of v1.7.33. As part of this, we update misc config of traefik-proxy as well that ships with the TLJH distribution. |
Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
|
It's possible the 0.2.0 upgrade test failed because of #895. I don't understand the error message well enough to be sure, but I ran a test deployment and can confirm that without the PATH change upgrading from 0.2.0 to jupyterhub 4 does not work, so I don't really understand why the test are passing most of the time. It could be that the initial 0.2.0 setup doesn't let old jupyterhub get fully set up enough. |
seems to be why it fails sometimes
Co-authored-by: Mridul Seth <mail@mriduls.com>
|
All green! The intermittent failure in the integration test seems to be increasing in frequency. I still don't really understand the cause. |
Always chomp left, never right. This is what we do in the helm chart templates and has been very easy to be consistent with for a good result with little to no issues.
|
Yes, thanks! I still don't have good intuition for chomping. |
|
❤️ 🎉 wieeeeeeeeeeeeeeeee!!!! Thank you @minrk for your efforts into this!!!! |
Updates:
traefik v2 totally changed their config file format, so several config options needed to move around, but ultimately the behavior is unchanged. jupyterhub-traefik-proxy 1.0 is required to use traefik v2 due to the config and API changes. Some configuration is no longer required as jupyterhub-traefik-proxy writes initial dynamic config (api route, auth) during its startup, instead of requiring to duplicate that info to the traefik config file.
This is a breaking change for the rare cases where users configured traefik or TraefikProxy directly, since both are major changes, but for most users the change should not be noticed (🤞) except as a performance boost when there are many users.
closes #513