Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google auth docs #898

Merged
merged 4 commits into from May 18, 2023

Conversation

jrdnbradford
Copy link
Contributor

My institution uses TLJH on Google Cloud and uses Google Workspace for auth, specifically Google Groups.

This PR fills out some of the TLJH Google auth docs and makes some small changes to a linked page.

@welcome
Copy link

welcome bot commented May 18, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wieee thank you @jrdnbradford, this looks great!

I appreciate especially that you also linked out to the oauthenticator documentation on how to configure GoogleOAuthenticator as a reference.

By default, the following allows anyone with a Google account to login.
You can set specific allowed users and admins using .

This may change in the future and is discussed in jupyterhub/oauthenticator#609.

@consideRatio consideRatio merged commit 282af83 into jupyterhub:main May 18, 2023
2 checks passed
@welcome
Copy link

welcome bot commented May 18, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@jrdnbradford
Copy link
Contributor Author

Awesome, thanks @consideRatio. 👍🏼

@jrdnbradford jrdnbradford deleted the update-google-auth-docs branch May 22, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants