Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http[s].address config to control where traefik listens #905

Merged
merged 4 commits into from May 25, 2023

Conversation

nsurleraux-railnova
Copy link
Contributor

@nsurleraux-railnova nsurleraux-railnova commented May 25, 2023

This PR allows using http.address and https.address to set the addresses that TLJH will listen on,
which is an empty address by default (it means it listens on all interfaces by default, as it is the current behavior).

Tested and documented also!

Close #903

@welcome
Copy link

welcome bot commented May 25, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you for the test and docs!

@minrk minrk added the new label May 25, 2023
@minrk minrk merged commit 2d645a7 into jupyterhub:main May 25, 2023
12 checks passed
@welcome
Copy link

welcome bot commented May 25, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@minrk minrk changed the title Add a Traefik configuration to listen on a specific address (#903) Add http[s].address config to control where traefik listens May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot bind traefik on a specific interface without breaking tljh-config reload hub
2 participants