Quote pwd to prevent error if dir has spaces
#917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
reviewed
Jun 6, 2023
| @@ -24,7 +24,7 @@ The easiest & safest way to develop & test TLJH is with [Docker](https://www.doc | |||
| --detach \ | |||
| --name=tljh-dev \ | |||
| --publish 12000:80 \ | |||
| --mount type=bind,source=$(pwd),target=/srv/src \ | |||
| --mount type=bind,source="$(pwd)",target=/srv/src \ | |||
There was a problem hiding this comment.
I'm always a bit uncertain about putting quotes in the middle of a string, but you tested this and it worked?
There was a problem hiding this comment.
Same! It has been tested. Command continues to run correctly when the source path has no spaces as before, and now works if there are spaces since "$(pwd)" gets expanded and quoted.
consideRatio
approved these changes
Jun 6, 2023
|
Thank you @jrdnbradford!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very small change to the
docker runcommand so that it works even if the path to your working directory has spaces. 馃槉