test refactor: put bootstrap tests in an isolated job, save ~3 min in each of the integration test jobs #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
force-pushed
the
pr/isolate-bootstraptests-to-a-dedicated-job
branch
from
e21307b
to
f21b38a
Compare
consideRatio
force-pushed
the
pr/isolate-bootstraptests-to-a-dedicated-job
branch
from
f21b38a
to
0c914af
Compare
consideRatio
changed the title
minrk
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a odd test, the integration-tests/test_bootstrap.py, that is different from the other integration tests. It can be refactored further and made like the others I think, but for now, let's not run it in sequence with the other tests, but isolate it.
Isolating it makes us not run it for each supported linux distribution for now, but we reduce test duration by ~3 minutes or so.
Another key benefit of separating this is that its easier to understand that test_bootstrap.py currently is quite different from the other integration tests, and has different needs etc, allowing future refactoring and general maintenance easier.