breaking: update oauthenticator from 15.1.0 to >=16.0.2,<17, make tljh auth docs link out #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
This was referenced Jul 5, 2023
consideRatio
changed the title
consideRatio
force-pushed
the
pr/update-oauthenticator-16
branch
from
9cfd8b7
to
c6fed71
Compare
minrk
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I think it would be good if we could update all the authentication documentation, I don't think we should try get that done before a release. So instead of doing that, I made disclaimers to the documentation we had, suggesting that for example the OAuthenticator project's documentation should be used pirmarily and the tljh provided docs should be used as a complement only.
This is a preview of the warning, and you can preview it in the read the docs PR build here: