Document code-review practices #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is by no means complete or comprehensive, but it is a start! Feel free to comment here on this PR, or open issues for ways to improve this :) |
There was a problem hiding this comment.
Woooooo this was a great addition! Can I copy paste it to z2jh later? We have a lot of work to do regarding testing there still though =)
I'm picking up a lot of wisdom and knowledge from you @yuvipanda thank you =D ❤️
|
|
||
| We recommend reading `On Empathy & Pull Requests <https://slack.engineering/on-empathy-pull-requests-979e4257d158>`_ | ||
| and `How about code reviews <https://slack.engineering/how-about-code-reviews-2695fb10d034>`_ | ||
| to learn more about being empathetic in code reviews. |
There was a problem hiding this comment.
Looking forward to read these articles!
| - [ ] Add / update documentation | ||
| - [ ] Add tests | ||
|
|
||
| <!-- Read more about our code-review guidelines at https://the-littlest-jupyterhub.readthedocs.io/en/latest/contributing/code-review.html --> |
There was a problem hiding this comment.
I've seen a lot of templates, I think this is perfect - useful and easy.
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a pull request template