fix coverage uploads #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
force-pushed
the
fix-coverage
branch
2 times, most recently
from
70792c2
to
6f0fcab
Compare
needed for codecov to find necessary commands codecov appears to need git as well environment variables must be set at runtime using a weird [$BASH_ENV trick](https://circleci.com/docs/2.0/env-vars/#using-bash_env-to-set-environment-variables) since circle doesn't support simple `PATH: bin:$PATH` in the environment variable spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codecov upload has been failing since #72. I think because
coverageis not installed on $PATH.Activating the env should fix it, but will wait for CI to confirm.It works. Had to use a bizarreecho export >> $BASH_ENVsnippet because circleci doesn't support setting standard environment variables.