restore proxy tests #167
Merged
restore proxy tests #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2023
manics
reviewed
Mar 5, 2023
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
and make sure to check the returncode
minrk
force-pushed
the
restore-proxy-tests
branch
from
9db30b6
to
174be9a
Compare
if we want re-usable tests, let's move them to pytest-jupyterhub
|
Since the reasoning behind the separate The failure was due to the trailing-line stripping in |
remove unused fixtures, consolidate etcd args, use ssl args everywhere auth is enabled, not just most places
ensures they are run in the right order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed in #157, actually deleted most of our tests!