Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customising the proxy image choices via the Helm chart #1383

Closed
mz2 opened this issue Sep 3, 2019 · 3 comments
Closed

Allow customising the proxy image choices via the Helm chart #1383

mz2 opened this issue Sep 3, 2019 · 3 comments

Comments

@mz2
Copy link

mz2 commented Sep 3, 2019

The JupyterHub Helm chart at the moment allows for the hub and singleuser notebook server image to be configured. There is no (at least documented?) facility for doing the same for the proxy images. I mean these kinds of properties are missing for the images involved in the proxy service:

  image:
    name: ...
    tag: ...
  imagePullSecret:
    username: ...
    password: ...
    registry: ...
    enabled: ...
@manics
Copy link
Member

manics commented Sep 3, 2019

The proxy has multiple containers:

chp:
image:
name: jupyterhub/configurable-http-proxy
tag: 4.1.0
resources:
requests:
cpu: 200m
memory: 512Mi
nginx:
image:
name: quay.io/kubernetes-ingress-controller/nginx-ingress-controller
tag: 0.15.0
proxyBodySize: 64m
hstsIncludeSubdomains: 'false'
resources: {}
lego:
image:
name: jetstack/kube-lego
tag: 0.1.7
resources: {}

What do you need to configure?

@mz2
Copy link
Author

mz2 commented Sep 3, 2019

Good point, adjusted issue title + description to note that.

This is related to https://discourse.jupyter.org/t/intercepting-requests-to-jupyter-notebook-server/2046 – my plan was to alter the configurable-http-proxy containing image for my purposes (I'd like to intercept some specific endpoints), but to be honest I could use advice on that.

@mz2 mz2 changed the title Allow customising the proxy image choice via the Helm chart Allow customising the proxy image choices via the Helm chart Sep 3, 2019
@consideRatio
Copy link
Member

This is now possible

containers:
- name: chp
image: {{ .Values.proxy.chp.image.name }}:{{ .Values.proxy.chp.image.tag }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants