Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak #59 #62

Merged
merged 3 commits into from Sep 9, 2021
Merged

fix memory leak #59 #62

merged 3 commits into from Sep 9, 2021

Conversation

eastonsuo
Copy link
Contributor

fix memory leak #59 by limiting both _write_buffer of RequstHandler, ……as well as _write_buffer of IOStream

@eastonsuo
fix memory leak jupyterlab-contrib#59 by limiting both _write_buffer …
bdbc0b5 
…of RequstHandler, as well as _write_buffer of IOStream
@eastonsuo
Copy link
Contributor Author

related with #60 #59

fcollonval
fcollonval requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly updating the PR.

I left some additional comments.

jupyter_archive/__init__.py Outdated Show resolved Hide resolved
jupyter_archive/__init__.py Outdated Show resolved Hide resolved
jupyter_archive/handlers.py Show resolved Hide resolved
jupyter_archive/handlers.py Outdated Show resolved Hide resolved
@eastonsuo
Copy link
Contributor Author

eastonsuo commented Sep 7, 2021 •
edited

Thanks for quickly updating the PR.

I left some additional comments.

thx for advices and I have fixed them, could have a review ^^@fcollonval

@fcollonval
Copy link
Member

Thanks a lot @eastonsuo

I added some documentation for the new configuration settings in the README and I think we are good to go.

@fcollonval fcollonval merged commit 8d9caa3 into jupyterlab-contrib:master Sep 9, 2021
@fcollonval fcollonval mentioned this pull request Sep 9, 2021
Closed
@fcollonval fcollonval mentioned this pull request Jan 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eastonsuo @fcollonval